Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate separate registrations #48

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

mvarendorff2
Copy link
Member

This PR adds support for adding individual ES components (like Validators or Policies) to a servicecollection instead of getting either all or nothing.

@mvarendorff2 mvarendorff2 force-pushed the feat/generate-separate-registrations branch 2 times, most recently from f20019a to bece01e Compare October 1, 2024 11:00
@mvarendorff2 mvarendorff2 force-pushed the feat/generate-separate-registrations branch from bece01e to b45207c Compare October 1, 2024 11:14
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 98.64865% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.39%. Comparing base (949242e) to head (b45207c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/Fluss.Regen/SelectorGenerator.cs 98.43% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
+ Coverage   66.62%   67.39%   +0.77%     
==========================================
  Files          75       75              
  Lines        2873     2926      +53     
  Branches      303      315      +12     
==========================================
+ Hits         1914     1972      +58     
+ Misses        906      901       -5     
  Partials       53       53              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mvarendorff2 mvarendorff2 merged commit 8aef8b8 into main Oct 1, 2024
7 of 10 checks passed
@mvarendorff2 mvarendorff2 deleted the feat/generate-separate-registrations branch October 1, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant